Improve cunumeric.prod coverage and some test fixes#905
Merged
yimoj merged 3 commits intonv-legate:branch-23.05from May 4, 2023
Merged
Improve cunumeric.prod coverage and some test fixes#905yimoj merged 3 commits intonv-legate:branch-23.05from
yimoj merged 3 commits intonv-legate:branch-23.05from
Conversation
bryevdv
reviewed
Apr 24, 2023
bryevdv
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prodcoverage to 100%test_dtype_negative-->test_dtype_integer_precision, this is not a negative test.test_dtype_complex_negativeis removed, parameters are merged intotest_dtype_complextest_axis_tuple--> moved into positive testsLEGATE_TEST=1orCUNUMERIC_TEST=1is not set.cunumeric.place, some of the lines slipped through after the last change in Improve code coverage in array_split/unpackbits/place #892