Skip to content

Improve cunumeric.prod coverage and some test fixes#905

Merged
yimoj merged 3 commits intonv-legate:branch-23.05from
yimoj:prod_coverage
May 4, 2023
Merged

Improve cunumeric.prod coverage and some test fixes#905
yimoj merged 3 commits intonv-legate:branch-23.05from
yimoj:prod_coverage

Conversation

@yimoj
Copy link
Contributor

@yimoj yimoj commented Apr 24, 2023

  • Improve prod coverage to 100%
  • Rearrange some of the tests into the correct test class and changed the naming.
    • test_dtype_negative --> test_dtype_integer_precision, this is not a negative test.
    • test_dtype_complex_negative is removed, parameters are merged into test_dtype_complex
    • test_axis_tuple --> moved into positive tests
  • Add more comments to some of the xfail tests to indicate the repro condition
  • Compare exceptions in negative tests.
  • Fix the coverage for cunumeric.place, some of the lines slipped through after the last change in Improve code coverage in array_split/unpackbits/place #892

@yimoj yimoj added the category:task PR is a simple task and will not be included in release notes label Apr 24, 2023
@yimoj yimoj requested a review from bryevdv April 24, 2023 10:34
@yimoj yimoj merged commit d41aa7c into nv-legate:branch-23.05 May 4, 2023
@yimoj yimoj deleted the prod_coverage branch May 8, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:task PR is a simple task and will not be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants