Enhance mask_indices and move_axis#622
Merged
robinwnv merged 3 commits intonv-legate:branch-22.10from Sep 30, 2022
Merged
Conversation
bryevdv
approved these changes
Sep 29, 2022
Contributor
bryevdv
left a comment
There was a problem hiding this comment.
These changes are very nice, only a few small comments
Comment on lines
+21
to
+22
| KS = [0, -1, 1, -2, 2] | ||
| FUNCTIONS = ["tril", "triu"] |
Contributor
There was a problem hiding this comment.
prefer tuples unless mutability is an explicit need
Suggested change
| KS = [0, -1, 1, -2, 2] | |
| FUNCTIONS = ["tril", "triu"] | |
| KS = (0, -1, 1, -2, 2) | |
| FUNCTIONS = ("tril", "triu") |
(here, and also several places below)
Contributor
Author
There was a problem hiding this comment.
You are right. Tuple is better than list if the case is immutable. Fixed.
tests/integration/test_moveaxis.py
Outdated
Comment on lines
+59
to
+63
| EMPTY_ARRAYS = [ | ||
| [], | ||
| [[]], | ||
| [[], []], | ||
| ] |
Contributor
There was a problem hiding this comment.
Suggested change
| EMPTY_ARRAYS = [ | |
| [], | |
| [[]], | |
| [[], []], | |
| ] | |
| EMPTY_ARRAYS = ( | |
| [], | |
| [[]], | |
| [[], []], | |
| ) |
|
|
||
| msg = "'str' object is not callable" | ||
| with pytest.raises(TypeError, match=msg): | ||
| num.mask_indices(10, "abc") |
Contributor
There was a problem hiding this comment.
This would be better split into two separate named tests
| cn.moveaxis(self.x, None, 0) | ||
|
|
||
| with pytest.raises(TypeError, match=msg): | ||
| cn.moveaxis(self.x, 0, None) |
Contributor
There was a problem hiding this comment.
split into separate tests for float and None
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
…622) Note: the test failures are not related to this change. * Renamed: .github/workflows/ci-gh-release.yml -> .github/workflows/ci-gh.yml. Also changed the build-type to ci. * Use build_release_product to build ci package. * Use make_release_env() for ci builds too. * The nightly build now has build-type set to nightly instead of release. * Updated versions.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.