Make the negative test on fill robust across Python versions#619
Merged
magnatelee merged 1 commit intonv-legate:branch-22.10from Sep 29, 2022
Merged
Conversation
Contributor
Author
|
cc @xialu00 you may consider making your negative checks more robust as this PR. Error messages don't change frequently, but they don't seem to be set in stone either. |
Contributor
|
Thanks for your advice. That is very helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_fill_int_with_nonewas using a Python version-specific error string and failing on Python 3.10. This PR makes it more robust.