Refactor scalar reductions to use common execution policy#573
Refactor scalar reductions to use common execution policy#573jjwilke merged 6 commits intonv-legate:branch-22.10from
Conversation
for more information, see https://pre-commit.ci
|
@jjwilke please add a copyright header to the new files |
|
left two nitpick-y comments. otherwise looks good. |
|
@magnatelee Should be ready to merge. There was an additional change required to unary_red_util.h you might want to glance at. |
| #define CUDA_FUNCTION | ||
| #endif | ||
|
|
||
| #endif // SRC_CUNUMERIC_EXECUTION_POLICY_EXECUTION_POLICY_HELPERS_H_ No newline at end of file |
There was a problem hiding this comment.
Missing newline at end of file. Weird that the clang auto-formatter didn't catch that. Does it look like clang-format is running when you make change to header files? It might be that the filename pattern is skipping header files, or maybe just our clang-format configuration isn't checking for missing newlines at end of files.
Feel free to merge this once you remove the obsolete header file. |
Following the design doc for improving code reuse, this implements all scalar reduction kernels through a single implementation.