Fix a compiler warning#555
Merged
magnatelee merged 1 commit intonv-legate:branch-22.10from Aug 24, 2022
Merged
Conversation
Contributor
Author
|
@manopapad please confirm that this PR fixes the warning you're seeing |
manopapad
approved these changes
Aug 23, 2022
Contributor
manopapad
left a comment
There was a problem hiding this comment.
Yes, this fixes the warning. The actual code works with and w/o this fix, so the emitted code doesn't change, it's probably just a false positive coming from nvcc.
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Sep 2, 2022
manopapad
pushed a commit
that referenced
this pull request
Feb 18, 2025
This pulls some CMake code from #528 to improve the logic around initializing the `CMAKE_CUDA_ARCHITECTURES` variable in the project. It fixes builds using CMake directly and offers more robust logic in light of `rapids-cmake` deprecating and removing the use of empty string there. This fixes issue #554.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some compiler doesn't like a single if-else statement in a value-returning function that has a return statement in both branches.