Argwhere and flatnonzero#525
Merged
mfoerste4 merged 10 commits intonv-legate:branch-22.10from Aug 24, 2022
Merged
Conversation
Contributor
Author
|
@magnatelee I suggested you for review, feel free to forward to someone else. |
magnatelee
requested changes
Aug 19, 2022
Contributor
|
left two petty comments. otherwise looks good to me. great to see that you reuse the kernels from the |
Contributor
Author
|
magnatelee
approved these changes
Aug 24, 2022
Contributor
|
@mfoerste4 approved. feel free to merge it whenever you can. |
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Sep 2, 2022
* extract counting routine to re-use with argwhere * added argwhere and flatnonzero * combine tests * add doc entry * fix mypy issues * adjusted test_config expectations * cleanup
manopapad
pushed a commit
that referenced
this pull request
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality for
np.argwhereandnp.flatnonzeroto cuNumeric.np.argwhere
Implemented similar to
np.nonzerotask, but with different return shapenp.flatnonzero
Just forwarded to
np.nonzero(np.ravel(a))[0]