Support for advanced indexing on 2d arrays#42
Closed
manopapad wants to merge 26 commits intonv-legate:mainfrom
Closed
Support for advanced indexing on 2d arrays#42manopapad wants to merge 26 commits intonv-legate:mainfrom
manopapad wants to merge 26 commits intonv-legate:mainfrom
Conversation
To avoid implicit casts when comparing with ints
fduguet-nv
pushed a commit
to fduguet-nv/cunumeric
that referenced
this pull request
Mar 29, 2022
Explicit checks for underlying Legion handle equality
Contributor
Author
|
This has been superseded by #235 |
manopapad
pushed a commit
to manopapad/cunumeric
that referenced
this pull request
Feb 14, 2024
* Port moveaxis and add tests * Refactor normalize_axis_index and normalize_axis_vector * Added tests to moveaxis for single element and empty array * Added tests to moveaxis for empty shapes * Added tests to moveaxis for different shapes (up to 7d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@magnatelee Please take a look and let me know how bad this conflicts with your ongoing work