Support axis=None and keepdims=True/False in argmin and argmax#346
Merged
trxcllnt merged 10 commits intonv-legate:branch-22.05from May 25, 2022
Merged
Support axis=None and keepdims=True/False in argmin and argmax#346trxcllnt merged 10 commits intonv-legate:branch-22.05from
axis=None and keepdims=True/False in argmin and argmax#346trxcllnt merged 10 commits intonv-legate:branch-22.05from
Conversation
for more information, see https://pre-commit.ci
Merged
Contributor
for more information, see https://pre-commit.ci
magnatelee
approved these changes
May 23, 2022
manopapad
pushed a commit
to manopapad/cunumeric
that referenced
this pull request
Sep 7, 2022
…ar` (nv-legate#346) * Specify the upper bound of return value sizes for core::extract_scalar * Apply the demux logic for futures to future maps of size 1 * Replace NULL with nullptr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the work for #87
axis=Noneandkeepdims: boolinnp.argminandnp.argmaxI'm taking a slightly less optimal path by flattening then broadcasting to two dimensions when
axis=None, because scalarargmin/argmaxreductions aren't implemented inlibcunumericyet. I can take a stab at implementing these reductions in C++, but this was a quicker way to achieve the same behavior.