adding 'only' option to the tests.py#248
Merged
ipdemes merged 2 commits intonv-legate:branch-22.05from Apr 6, 2022
Merged
Conversation
Merged
magnatelee
reviewed
Apr 4, 2022
| legate_tests.extend(glob.glob("tests/interop/*.py")) | ||
| legate_tests.extend(glob.glob("tests/interop/*.py")) # noqa: F823 | ||
|
|
||
| if only_pattern is not None: |
Contributor
There was a problem hiding this comment.
Let's not repeat this, unless there's a reason good reason to do so. Can't you factor this and the same code above out?
test.py
Outdated
| ): | ||
| if interop_tests: | ||
| legate_tests.extend(glob.glob("tests/interop/*.py")) | ||
| legate_tests.extend(glob.glob("tests/interop/*.py")) # noqa: F823 |
Contributor
There was a problem hiding this comment.
Why do you need to override F823? We generally don't want overrides like this, unless there's no way around it. (as far as I know we use this override only for very long function names.)
test.py
Outdated
| ): | ||
| if interop_tests: | ||
| legate_tests.extend(glob.glob("tests/interop/*.py")) | ||
| legate_tests.extend(glob.glob("tests/interop/*.py")) # noqa: F823 |
Contributor
There was a problem hiding this comment.
Why do you need to override F823? We generally don't want overrides like this, unless there's no way around it. (as far as I know we use this override only for very long function names.)
Contributor
Author
There was a problem hiding this comment.
it was a leftover, removed
Contributor
Author
|
@magnatelee : can I merge this? |
Contributor
|
Yes. Please merge it when you can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.