Fix coverage for ufuncs#240
Merged
bryevdv merged 1 commit intonv-legate:branch-22.03from Mar 29, 2022
bryevdv:bryanv/ufunc_coverage
Merged
Fix coverage for ufuncs#240bryevdv merged 1 commit intonv-legate:branch-22.03from bryevdv:bryanv/ufunc_coverage
bryevdv merged 1 commit intonv-legate:branch-22.03from
bryevdv:bryanv/ufunc_coverage
Conversation
bryevdv
commented
Mar 29, 2022
|
|
||
| # todo: (bev) use callback protocol type starting with 3.8 | ||
| def implemented(func: Any, prefix: str) -> Any: | ||
| name = f"{prefix}.{func.__name__}" |
Contributor
Author
There was a problem hiding this comment.
Can't rely on __name__ since binary_ufunc, etc do not have
Contributor
There was a problem hiding this comment.
I can add that property if that's necessary.
Contributor
Author
|
noting all tests pass for me locally with |
ipdemes
pushed a commit
to ipdemes/cunumeric
that referenced
this pull request
Jun 7, 2022
manopapad
added a commit
that referenced
this pull request
Nov 17, 2024
The conda install will take care of this automatically, and this list will almost certainly bitrot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue with ufuncs not being considered in the coverage reports, and also fixed them being missing from the comarison table: