fixing _comparison script used for API coverage table#237
Closed
ipdemes wants to merge 1 commit intonv-legate:branch-22.05from
Closed
fixing _comparison script used for API coverage table#237ipdemes wants to merge 1 commit intonv-legate:branch-22.05from
ipdemes wants to merge 1 commit intonv-legate:branch-22.05from
Conversation
magnatelee
reviewed
Mar 28, 2022
| .. ndarray.sort | ||
| .. ndarray.argsort | ||
| .. ndarray.partition | ||
| .. ndarray.argpartition |
Contributor
There was a problem hiding this comment.
can you tell me why you had to remove this line? Looks like this line was already commented out, so I'm surprised how this could contribute to what you were seeing.
| for f in _get_functions(lg_obj): | ||
| obj = getattr(lg_obj, f) | ||
| if obj.__doc__ is None or "Unimplemented" not in obj.__doc__: | ||
| if obj.__doc__ is not None and ("GPU" in obj.__doc__): |
Contributor
There was a problem hiding this comment.
You should consider using what this coverage tool is doing for identifying unimplemented operations:
https://github.com/nv-legate/cunumeric/blob/777de2e017808ab7244d8f781662cd1c290cf2c8/cunumeric/coverage.py#L76
Predicates like what you wrote can be very brittle.
Merged
Contributor
Author
|
Closing this PR since #239 fixes the issue |
ipdemes
pushed a commit
to ipdemes/cunumeric
that referenced
this pull request
Jun 7, 2022
* Move FieldID to a separate module to fix the unrodered field destruction * Fix the typing for Fill
manopapad
pushed a commit
that referenced
this pull request
Nov 17, 2024
Co-authored-by: Mark Vaz <m3vaz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.