Skip to content

Fix compilation errors on clang #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manopapad merged 1 commit into from
Mar 25, 2022
Merged

Fix compilation errors on clang #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/cunumeric/unary/unary_op_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,8 +560,7 @@ struct UnaryOp<UnaryOpCode::EXP2, legate::LegateTypeCode::HALF_LT> {
template <legate::LegateTypeCode CODE>
struct UnaryOp<UnaryOpCode::EXPM1, CODE> {
static constexpr bool valid = is_floating_or_complex<CODE>;
;
using T = legate::legate_type_of<CODE>;
using T = legate::legate_type_of<CODE>;

UnaryOp(const std::vector<legate::Store>& args) {}

Expand All @@ -576,7 +575,7 @@ struct UnaryOp<UnaryOpCode::EXPM1, CODE> {
constexpr decltype(auto) operator()(const T& x) const
{
using std::exp;
return exp(x) - 1;
return exp(x) - T(1);
}
};

Expand Down Expand Up @@ -800,7 +799,7 @@ struct UnaryOp<UnaryOpCode::LOG1P, CODE> {
constexpr decltype(auto) operator()(const T& x) const
{
using std::log;
return log(1 + x);
return log(T(1) + x);
}
};

Expand Down Expand Up @@ -928,7 +927,7 @@ struct UnaryOp<UnaryOpCode::RECIPROCAL, CODE> {
constexpr T operator()(const T& x) const
{
// TODO: We should raise an exception for any divide-by-zero attempt
return x != 0 ? 1 / x : 0;
return x != T(0) ? T(1) / x : 0;
}
};

Expand Down