Skip to content

Fix trailing comma tuple bug#230

Merged
magnatelee merged 1 commit intonv-legate:branch-22.03from
bryevdv:bryanv/coverage_hotfix
Mar 24, 2022
Merged

Fix trailing comma tuple bug#230
magnatelee merged 1 commit intonv-legate:branch-22.03from
bryevdv:bryanv/coverage_hotfix

Conversation

@bryevdv
Copy link
Contributor

@bryevdv bryevdv commented Mar 23, 2022

This is a focused hotfix PR for the bug discovered and fixed in #229 in case it is preferable to merge a smaller PR for now. cc @magnatelee

@bryevdv bryevdv mentioned this pull request Mar 23, 2022
@bryevdv
Copy link
Contributor Author

bryevdv commented Mar 23, 2022

With this PR:

>>> import cunumeric
>>> for k, v in cunumeric.__dict__.items():  
...     if isinstance(v, tuple): print(k, v)
... 
ScalarType (<class 'int'>, <class 'float'>, <class 'complex'>, <class 'int'>, <class 'bool'>, <class 'bytes'>, <class 'str'>, <class 'memoryview'>, <class 'numpy.bool_'>, <class 'numpy.complex64'>, <class 'numpy.complex128'>, <class 'numpy.complex256'>, <class 'numpy.float16'>, <class 'numpy.float32'>, <class 'numpy.float64'>, <class 'numpy.float128'>, <class 'numpy.int8'>, <class 'numpy.int16'>, <class 'numpy.int32'>, <class 'numpy.longlong'>, <class 'numpy.int64'>, <class 'numpy.timedelta64'>, <class 'numpy.datetime64'>, <class 'numpy.object_'>, <class 'numpy.bytes_'>, <class 'numpy.str_'>, <class 'numpy.uint8'>, <class 'numpy.uint16'>, <class 'numpy.uint32'>, <class 'numpy.ulonglong'>, <class 'numpy.uint64'>, <class 'numpy.void'>)
kernel_version (5, 10)

correct compared to actual numpy:

In [68]: >>> for k, v in np.__dict__.items():
    ...: ...     if isinstance(v, tuple): print(k, v)
    ...: 
ScalarType (<class 'int'>, <class 'float'>, <class 'complex'>, <class 'int'>, <class 'bool'>, <class 'bytes'>, <class 'str'>, <class 'memoryview'>, <class 'numpy.bool_'>, <class 'numpy.complex64'>, <class 'numpy.complex128'>, <class 'numpy.complex256'>, <class 'numpy.float16'>, <class 'numpy.float32'>, <class 'numpy.float64'>, <class 'numpy.float128'>, <class 'numpy.int8'>, <class 'numpy.int16'>, <class 'numpy.int32'>, <class 'numpy.longlong'>, <class 'numpy.int64'>, <class 'numpy.datetime64'>, <class 'numpy.timedelta64'>, <class 'numpy.object_'>, <class 'numpy.bytes_'>, <class 'numpy.str_'>, <class 'numpy.uint8'>, <class 'numpy.uint16'>, <class 'numpy.uint32'>, <class 'numpy.ulonglong'>, <class 'numpy.uint64'>, <class 'numpy.void'>)
kernel_version (5, 10)

@magnatelee magnatelee merged commit c55ef40 into nv-legate:branch-22.03 Mar 24, 2022
@bryevdv bryevdv mentioned this pull request Mar 28, 2022
ipdemes pushed a commit to ipdemes/cunumeric that referenced this pull request Jun 7, 2022
- Switch to using openblas from conda instead of downloading and compiling during legate compilation

- Fix some formatting in the conda recipe
ipdemes pushed a commit to ipdemes/cunumeric that referenced this pull request Jun 7, 2022
manopapad pushed a commit that referenced this pull request Nov 17, 2024
* enhance coverage for _array/*.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants