Fix some docs breakage#224
Merged
bryevdv merged 1 commit intonv-legate:branch-22.03from Mar 22, 2022
bryevdv:bryanv/docs_fixups
Merged
Fix some docs breakage#224bryevdv merged 1 commit intonv-legate:branch-22.03from bryevdv:bryanv/docs_fixups
bryevdv merged 1 commit intonv-legate:branch-22.03from
bryevdv:bryanv/docs_fixups
Conversation
bryevdv
commented
Mar 20, 2022
magnatelee
reviewed
Mar 22, 2022
Contributor
|
LGTM except for the typo I mentioned. |
ipdemes
pushed a commit
to ipdemes/cunumeric
that referenced
this pull request
Jun 7, 2022
manopapad
pushed a commit
that referenced
this pull request
Nov 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions were added without docstrings and/or added without adding to the relevant Sphinx ReST file. Additionally there are a few numpy methods that are not present in our API (see comment below). Finally, there is still a placeholder section in the array methods page for things that don't seem to have a counterpart in the numpy array docs page. We just need to decide where they go:
cc @magnatelee