Closed
Conversation
ae89065 to
5c1dd42
Compare
bdc493e to
0da9dca
Compare
0da9dca to
7793cc9
Compare
manopapad
reviewed
Mar 22, 2022
src/cunumeric/index/zip_template.inl
Outdated
Comment on lines
+56
to
+58
| #ifdef LEGION_BOUNDS_CHECKS | ||
| bool dense = false; | ||
| #endif |
Contributor
There was a problem hiding this comment.
Move this as an #else above where dense is defined. Otherwise line 53 will not compile if LEGION_BOUNDS_CHECKS is defined.
manopapad
reviewed
Mar 22, 2022
| const size_t volume = rect.volume(); | ||
| if (dense) { | ||
| auto outptr = out.ptr(rect); | ||
| for (size_t idx = 0; idx < volume; ++idx) { |
Contributor
There was a problem hiding this comment.
I would cache the input array pointers here; there may be some math needed to compute them, might as well not do it for every element.
Contributor
|
Still working on enumerating all special cases, to make sure we're covering everything. So far I came up with this counterexample, where NumPy and cuNumeric are producing different results: prints: |
Contributor
Author
|
Thank you @manopapad ! I will try to fix it ASAP |
c60717d to
8535ba3
Compare
Contributor
Author
|
Closing a PR due to the GitHub issues. Will reopen it shortly |
ipdemes
pushed a commit
to ipdemes/cunumeric
that referenced
this pull request
Jun 7, 2022
* Bump minpy to 3.8 * Update README * Revert "Update README" This reverts commit 5df94c2dcf6c2b60ee1132647502cbb7b456634f. * placate conda Co-authored-by: Manolis Papadakis <mpapadakis@nvidia.com>
manopapad
pushed a commit
that referenced
this pull request
Nov 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.