Skip to content

fix: pass params as part of api path#35

Merged
Tahul merged 5 commits intomainfrom
fix/query-params-as-path
Sep 18, 2022
Merged

fix: pass params as part of api path#35
Tahul merged 5 commits intomainfrom
fix/query-params-as-path

Conversation

@farnabaz
Copy link
Collaborator

@farnabaz farnabaz commented Aug 23, 2022

🔗 Linked issue

resolves #33

See comment #33 (comment)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Netlify bundler removes remark-github from the bundled projects since it cannot detect usage.
The solution for netlify deployment is to create netlify.toml and add remark-github and external node modules

[functions]
  node_bundler = "esbuild"
  external_node_modules = ["remark-github"]

The netlify.toml is not required, unless users set option remarkPlugin = true in nuxt.config

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@farnabaz farnabaz requested a review from Tahul August 23, 2022 15:25
@netlify
Copy link

netlify bot commented Aug 23, 2022

Deploy Preview for nuxt-github-module failed.

Name Link
🔨 Latest commit 9f866ad
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-github-module/deploys/6306479af154a90008b7b384

@Tahul Tahul merged commit d9ea72f into main Sep 18, 2022
@Tahul Tahul deleted the fix/query-params-as-path branch September 18, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse content for releases throw error only on production

3 participants