Skip to content

feat: support compatibility version map (for image) #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pi0 merged 2 commits into from
Sep 19, 2023
Merged

feat: support compatibility version map (for image) #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c41886
feat: support compatibility version map (for image)
pi0 Sep 19, 2023
3b03549
simplify
pi0 Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ import type { categories } from './categories'
// TODO: Support version matrix
export interface ModuleCompatibility {
nuxt: string
versionMap: {
[nuxtVersion: string]: string
}
requires: { bridge?: boolean | 'optional' },
}

Expand Down
3 changes: 3 additions & 0 deletions modules/image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,6 @@ compatibility:
nuxt: ^2.0.0 || ^3.0.0
requires:
bridge: optional
versionMap:
2.x: latest
Copy link
Copy Markdown
Member

@danielroe danielroe Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense for the map to be [any semver string]: any semver string rather than requiring it to be a tag?

edit: or maybe this is already what you have in mind

Copy link
Copy Markdown
Member Author

@pi0 pi0 Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes both sides are semver compatible (righthand is basically whatever npm i pkg@contraint allows)

Copy link
Copy Markdown
Member

@atinux atinux Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

3.x: rc