Skip to content

Fix help flag#4398

Merged
sophiajt merged 2 commits into
nushell:mainfrom
sophiajt:fix_help_flag
Feb 10, 2022
Merged

Fix help flag#4398
sophiajt merged 2 commits into
nushell:mainfrom
sophiajt:fix_help_flag

Conversation

@sophiajt
Copy link
Copy Markdown
Contributor

Description

This change brings help <command name> and <command name> --help to the same level. The two should now show identical help.

> grid --help
Renders the output to a textual terminal grid.

grid was built to give a concise gridded layout for ls. however,
it determines what to put in the grid by looking for a column named
'name'. this works great for tables and records but for lists we
need to do something different. such as with '[one two three] | grid'
it creates a fake column called 'name' for these values so that it
Usage:
  > grid {flags} 

      Display this help message
  -w, --width <Int>
      number of columns wide
  -c, --color
      draw output with color
  -s, --separator <String>
      character to separate grid with

cc @fdncred

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@sophiajt sophiajt merged commit c2118e7 into nushell:main Feb 10, 2022
@sophiajt sophiajt deleted the fix_help_flag branch February 10, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant