Conversation
There was a problem hiding this comment.
Pull request overview
Adds documentation updates for the NUnit Framework 4.5.1 patch release and documents a DefaultTimeout/.runsettings caveat for the VS Test adapter docs.
Changes:
- Add NUnit 4.5.1 release notes section (issues, acknowledgements) and normalize the 4.5.0 heading capitalization.
- Update the VS Test adapter Tips & Tricks
.runsettingstable to include a warning aboutDefaultTimeoutwith NUnit 4.5.0 on newer .NET runtimes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/articles/vs-test-adapter/Tips-And-Tricks.md | Expands the DefaultTimeout row in the .runsettings options table with a runtime/version warning. |
| docs/articles/nunit/release-notes/framework.md | Adds the NUnit 4.5.1 release notes section (enhancements/bug fixes/acknowledgements) above 4.5.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| | PrivateBinPath | string | directory1;directory2;etc | ? | | ||
| | RandomSeed | int | seed integer | random | | ||
| | DefaultTimeout | int | timeout in mS, 0 means infinite | 0 | | ||
| | DefaultTimeout | int | timeout in mS, 0 means infinite. Not for .net >5.0, error with NUnit 4.5.0 | 0 | |
There was a problem hiding this comment.
The DefaultTimeout description mixes in a version-/runtime-specific warning that’s currently ambiguous (".net >5.0"), uses inconsistent .NET capitalization, and doesn’t indicate whether the NUnit 4.5.0 problem is fixed in 4.5.1. Please rephrase using standard ".NET" terminology (e.g., ".NET 6+" if that’s what’s meant) and clarify the affected NUnit versions; consider moving the warning into a short note outside the table to keep the Options column consistent.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Releasenotes for NUnit 4.5.1 63089ff
No description provided.