llvm-py submodule#12
Conversation
|
This looks like a duplicate of a PR by @twiecki. Also, sorry for bundling the the DUP_TOPX and ROT_THREE patch here, I did git wrong. |
|
Yeah, I posted mine before I saw yours. Including llvm-py as a submodule is a little bit more user friendly so I think this here is better. |
|
I'm inclined to reject this, but I'm not fully fluent with git yet. What does having a submodule buy us versus an installation dependency? What happens if a user already has the llvm-py package installed? |
|
I think we need to reject this. llvmpy is a dependency. -Travis On Aug 13, 2012, at 1:55 PM, Jon Riehl wrote:
|
|
I agree, llvmpy is a dependency, not a subproject. |
|
Thanks for the comments. Closing. |
PR adds an llvm-py submodule, https submodule addressing (more firewall-friendly) and updates the README to match.