Skip to content

chore: pass window info in accumulator eof message #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yhl25 merged 1 commit into from
Jul 20, 2025
Merged

chore: pass window info in accumulator eof message #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/io/numaproj/numaflow/accumulator/AccumulatorActor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ private void sendEOF(String EOF) {
.newBuilder()
.setWindow(AccumulatorOuterClass.KeyedWindow
.newBuilder()
.setStart(this.keyedWindow.getStart())
.setEnd(this.keyedWindow.getEnd())
.addAllKeys(this.keyedWindow.getKeysList()))
.setEOF(true)
.build();
Expand Down
13 changes: 8 additions & 5 deletions src/main/java/io/numaproj/numaflow/accumulator/OutputStreamObserverImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
class OutputStreamObserverImpl implements OutputStreamObserver {
private final ActorRef outputActor;
private final AccumulatorOuterClass.KeyedWindow keyedWindow;
private final Instant latestWatermark = Instant.ofEpochMilli(-1);
private Instant latestWatermark = Instant.ofEpochMilli(-1);

public OutputStreamObserverImpl(
ActorRef outputActor,
Expand All @@ -26,14 +26,17 @@ public OutputStreamObserverImpl(

private AccumulatorOuterClass.AccumulatorResponse buildResponse(Message message) {
AccumulatorOuterClass.AccumulatorResponse.Builder responseBuilder = AccumulatorOuterClass.AccumulatorResponse.newBuilder();
if (message.getWatermark().isAfter(latestWatermark)) {
this.latestWatermark = message.getWatermark();
}
// set the window using the actor metadata.
responseBuilder.setWindow(AccumulatorOuterClass.KeyedWindow.newBuilder()
.setStart(Timestamp.newBuilder()
.setSeconds(0)
.setNanos(0))
.setNanos(0).build())
.setEnd(Timestamp.newBuilder()
.setSeconds(this.latestWatermark.getEpochSecond())
.setNanos(this.latestWatermark.getNano()))
.setNanos(this.latestWatermark.getNano()).build())
.setSlot("slot-0")
.addAllKeys(this.keyedWindow.getKeysList())
.build());
Expand All @@ -47,11 +50,11 @@ private AccumulatorOuterClass.AccumulatorResponse buildResponse(Message message)
.setEventTime(Timestamp
.newBuilder()
.setSeconds(message.getEventTime().getEpochSecond())
.setNanos(message.getEventTime().getNano()))
.setNanos(message.getEventTime().getNano()).build())
.setWatermark(Timestamp
.newBuilder()
.setSeconds(message.getWatermark().getEpochSecond())
.setNanos(message.getWatermark().getNano()))
.setNanos(message.getWatermark().getNano()).build())
.putAllHeaders(message.getHeaders())
.addAllKeys(message.getKeys()
== null ? new ArrayList<>() : Arrays.asList(message.getKeys()))
Expand Down
Loading