Skip to content

fix: avoid NullPointerExceptions if array element is null#194

Merged
adarsh0728 merged 2 commits intomainfrom
fix/ListOf
Jul 24, 2025
Merged

fix: avoid NullPointerExceptions if array element is null#194
adarsh0728 merged 2 commits intomainfrom
fix/ListOf

Conversation

@adarsh0728
Copy link
Copy Markdown
Member

@adarsh0728 adarsh0728 commented Jul 10, 2025

fixes #193

…of a null element

Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@da032c6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...numaflow/accumulator/OutputStreamObserverImpl.java 0.00% 0 Missing and 1 partial ⚠️
...ava/io/numaproj/numaflow/mapper/MapperTestKit.java 0.00% 1 Missing ⚠️
...java/io/numaproj/numaflow/reducer/ReduceActor.java 50.00% 0 Missing and 1 partial ⚠️
...aflow/reducestreamer/OutputStreamObserverImpl.java 0.00% 0 Missing and 1 partial ⚠️
...aflow/sessionreducer/OutputStreamObserverImpl.java 0.00% 0 Missing and 1 partial ⚠️
...ava/io/numaproj/numaflow/sinker/SinkerTestKit.java 0.00% 1 Missing ⚠️
...ow/sourcetransformer/SourceTransformerTestKit.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage        ?   58.80%           
  Complexity      ?      476           
=======================================
  Files           ?      151           
  Lines           ?     3389           
  Branches        ?      231           
=======================================
  Hits            ?     1993           
  Misses          ?     1229           
  Partials        ?      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adarsh0728 adarsh0728 changed the title fix: List.Of(..) - avoid NullPointerExceptions if element is null fix: avoid NullPointerExceptions if element is null Jul 10, 2025
@adarsh0728 adarsh0728 changed the title fix: avoid NullPointerExceptions if element is null fix: avoid NullPointerExceptions if array element is null Jul 10, 2025
@adarsh0728
Copy link
Copy Markdown
Member Author

Need to decide whether we want to preserve the null element in keys/tags

@adarsh0728 adarsh0728 marked this pull request as ready for review July 24, 2025 23:36
@adarsh0728 adarsh0728 merged commit a79f1fd into main Jul 24, 2025
5 checks passed
@adarsh0728 adarsh0728 deleted the fix/ListOf branch July 24, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid NullPointerException in cases where one of they keys in message.getKeys() is null

2 participants