Conversation
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage ? 58.76%
Complexity ? 476
=======================================
Files ? 151
Lines ? 3390
Branches ? 231
=======================================
Hits ? 1992
Misses ? 1231
Partials ? 167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RohanAshar
approved these changes
May 20, 2025
Contributor
RohanAshar
left a comment
There was a problem hiding this comment.
LGTM
Same comment as Krithika
Member
Author
|
Folks had concerns about backward compatibility. Discussed offline, we will rely on unit tests + numaflow main e2e tests to verify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix CVEs.
Test:
mvn clean installpassed.