Skip to content

chore: add checks to avoid panics if the users return null#180

Merged
KeranYang merged 2 commits intomainfrom
null
Apr 11, 2025
Merged

chore: add checks to avoid panics if the users return null#180
KeranYang merged 2 commits intomainfrom
null

Conversation

@yhl25
Copy link
Copy Markdown
Contributor

@yhl25 yhl25 commented Apr 10, 2025

No description provided.

Signed-off-by: Yashash H L <yashashhl25@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a884673). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../java/io/numaproj/numaflow/mapper/MapperActor.java 0.00% 4 Missing and 1 partial ⚠️
...j/numaflow/sourcetransformer/TransformerActor.java 0.00% 4 Missing and 1 partial ⚠️
...java/io/numaproj/numaflow/batchmapper/Service.java 80.00% 0 Missing and 4 partials ⚠️
...aproj/numaflow/mapstreamer/OutputObserverImpl.java 0.00% 1 Missing and 1 partial ⚠️
...main/java/io/numaproj/numaflow/sinker/Service.java 83.33% 0 Missing and 1 partial ⚠️
...io/numaproj/numaflow/sourcetransformer/Server.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage        ?   59.73%           
  Complexity      ?      467           
=======================================
  Files           ?      151           
  Lines           ?     3368           
  Branches        ?      205           
=======================================
  Hits            ?     2012           
  Misses          ?     1213           
  Partials        ?      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yhl25 yhl25 requested a review from adarsh0728 April 10, 2025 15:02
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
@vigith vigith requested a review from KeranYang April 10, 2025 17:38
@vigith vigith marked this pull request as ready for review April 10, 2025 17:38
@KeranYang KeranYang merged commit 1abeb29 into main Apr 11, 2025
5 checks passed
@KeranYang KeranYang deleted the null branch April 11, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants