Skip to content

fix: server not stopping locally#176

Merged
yhl25 merged 2 commits intonumaproj:mainfrom
EROIN:main
Mar 25, 2025
Merged

fix: server not stopping locally#176
yhl25 merged 2 commits intonumaproj:mainfrom
EROIN:main

Conversation

@EROIN
Copy link
Copy Markdown
Contributor

@EROIN EROIN commented Mar 25, 2025

This is caused by shutdown hooks that are added to perform cleanups on exit. However, when running it locally, they keep waiting for a SIGKILL and prevent regular shutdown. This is causing all integration tests to keep running indefinitely and never pass or fail.

Tested working locally.

This is caused by shutdown hooks that are added to perform cleanups on exit. However, when running it locally, they keep waiting for a SIGKILL and prevent regular shutdown. This is causing all integration tests to keep running indefinitely and never pass or fail

Signed-off-by: Eroin <eroinroderigo@gmail.com>
@yhl25 yhl25 requested review from KeranYang and yhl25 and removed request for yhl25 March 25, 2025 11:08
Copy link
Copy Markdown
Contributor

@yhl25 yhl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @EROIN for fixing this.

@yhl25 yhl25 merged commit dc7c4ea into numaproj:main Mar 25, 2025
3 checks passed
@yhl25 yhl25 mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants