chore: gracefully shutdown when error encountered#152
Merged
Conversation
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
KeranYang
commented
Nov 6, 2024
| } | ||
| } | ||
|
|
||
| public Server createServer( |
Member
Author
There was a problem hiding this comment.
This is mostly copied from GrpcServerUtils.java. We need to manage the state of event loop groups hence I created this class.
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
yhl25
approved these changes
Nov 6, 2024
Contributor
yhl25
left a comment
There was a problem hiding this comment.
I was under the impression that shutting down the server would also shut down the event loops.
The changes look good to me.
One suggestion: We shouldn't expose the event loop-related details to all the components. The event loops are only used by the io.grpc.Server. Instead of using GrpcServerHelper, could we write a wrapper for io.grpc.Server that exposes the necessary methods to create, start, gracefully stop, and force stop the server? This way, it can be abstracted out, and inside the wrapper, you can also shut down the event loops.
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
KeranYang
added a commit
to KeranYang/numaflow-java
that referenced
this pull request
Jan 22, 2025
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java Gracefully Shutdown Testing Notes
Test Pipeline
gRPC Server Log
gRPC Client Log
build
Test Pipeline
gRPC Server Log
gRPC Client Log
build
Test Pipeline
gRPC Server Log
gRPC Client Log
build
Test Pipeline
gRPC Server Log
gRPC Client Log
build
Test Pipeline
gRPC Server Log
gRPC Client Log
build
Test Pipeline
gRPC Server Log
gRPC Client Log
Build