Skip to content

feat: Unify MapStream and Unary Map Operations Using a Shared gRPC Protocol#146

Merged
yhl25 merged 2 commits intomainfrom
bidi-mapstream
Oct 14, 2024
Merged

feat: Unify MapStream and Unary Map Operations Using a Shared gRPC Protocol#146
yhl25 merged 2 commits intomainfrom
bidi-mapstream

Conversation

@yhl25
Copy link
Copy Markdown
Contributor

@yhl25 yhl25 commented Oct 13, 2024

No description provided.

…otocol

Signed-off-by: Yashash H L <yashashhl25@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a5cdc00). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...java/io/numaproj/numaflow/mapstreamer/Service.java 74.50% 12 Missing and 1 partial ⚠️
...ava/io/numaproj/numaflow/sinker/SinkerTestKit.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage        ?   60.53%           
  Complexity      ?      392           
=======================================
  Files           ?      126           
  Lines           ?     2762           
  Branches        ?      189           
=======================================
  Hits            ?     1672           
  Misses          ?      955           
  Partials        ?      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhl25 yhl25 marked this pull request as ready for review October 14, 2024 09:52
@yhl25 yhl25 requested review from KeranYang and vigith October 14, 2024 09:52
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
@yhl25 yhl25 merged commit 707c5bf into main Oct 14, 2024
@yhl25 yhl25 deleted the bidi-mapstream branch October 14, 2024 14:29
KeranYang pushed a commit to KeranYang/numaflow-java that referenced this pull request Jan 22, 2025
…otocol (numaproj#146)

Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants