Conversation
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
KeranYang
reviewed
Oct 6, 2024
| import java.util.Optional; | ||
| import java.util.concurrent.CompletableFuture; | ||
|
|
||
| /** |
Comment on lines
+46
to
+48
| CompletableFuture<Void> failureFuture = new CompletableFuture<>(); | ||
|
|
||
| handleFailure(failureFuture); |
Member
There was a problem hiding this comment.
why do we handle a failure future right after creating it?
Contributor
Author
There was a problem hiding this comment.
we handle failure using a separate thread.
|
|
||
| try { | ||
| responseObserver.done.get(); | ||
| } catch (InterruptedException | ExecutionException e) { |
Member
There was a problem hiding this comment.
nit: if there was no exception thrown, this unit test could pass. consider returning within the catch block and failing if reaching the end of the test.
| @Override | ||
| public SupervisorStrategy supervisorStrategy() { | ||
| // we want to stop all child actors in case of any exception | ||
| return new AllForOneStrategy( |
Member
There was a problem hiding this comment.
this is good. is it something we can also leverage for reduce stream/session?
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Member
|
LGTM! |
KeranYang
approved these changes
Oct 8, 2024
KeranYang
pushed a commit
to KeranYang/numaflow-java
that referenced
this pull request
Jan 22, 2025
…maproj#143) Signed-off-by: Yashash H L <yashashhl25@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.