Conversation
Signed-off-by: rashar <rohan_ashar@intuit.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
…into mapBatch Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
KeranYang
left a comment
There was a problem hiding this comment.
Partial Review. Thanks @RohanAshar for quickly pick this up and create the PR. 👍
yhl25
left a comment
There was a problem hiding this comment.
As discussed, let's use threads instead of Akka actors. Since we don't see much benefit in using actors over threads and also to be consistent with the current sink implementation.
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
src/main/java/io/numaproj/numaflow/batchmapper/BatchMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/batchmapper/BatchMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/batchmapper/DatumIterator.java
Outdated
Show resolved
Hide resolved
KeranYang
left a comment
There was a problem hiding this comment.
@RohanAshar one more comment and this is probably an unknown unknown to you - we have a build-push workflow, which automatically builds the example image using the latest change and push it to quay.io. Most of our examples are built into an image and used by numaflow e2e tests, having the auto image update help us ensure the SDK changes are validated by numaflow e2e. As we are going to use the example in the PR for batch map java e2e test, we should add it to the workflow yaml file. https://github.com/numaproj/numaflow-java/blob/main/development.md#adding-a-new-example
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
KeranYang
left a comment
There was a problem hiding this comment.
LGTM. I am approving with one minor comment. Please monitor the build-push workflow and enable e2e test on numaflow repo. Thanks!
src/main/java/io/numaproj/numaflow/batchmapper/BatchMapper.java
Outdated
Show resolved
Hide resolved
|
@RohanAshar I have manually created the repository https://quay.io/repository/numaio/numaflow-java/batch-map-example and granted the CI account permission to push the image. Should be good to monitor the build-push workflow after merging. |
Signed-off-by: rashar <rohan_ashar@intuit.com> Signed-off-by: RohanAshar <rohanashar1@gmail.com> Co-authored-by: rashar <rohan_ashar@intuit.com> Co-authored-by: Keran Yang <yangkr920208@gmail.com>
Fixes numaproj/numaflow#1789
Fixes numaproj/numaflow#1846