Skip to content

chore: force shutdown the server if not terminated gracefully#131

Merged
yhl25 merged 2 commits intomainfrom
force-shutdown
Jul 23, 2024
Merged

chore: force shutdown the server if not terminated gracefully#131
yhl25 merged 2 commits intomainfrom
force-shutdown

Conversation

@yhl25
Copy link
Copy Markdown
Contributor

@yhl25 yhl25 commented Jul 23, 2024

No description provided.

Signed-off-by: Yashash H L <yashashhl25@gmail.com>
@yhl25 yhl25 requested review from KeranYang and vigith July 23, 2024 17:18
@yhl25 yhl25 merged commit 3c2ec6f into main Jul 23, 2024
@yhl25 yhl25 deleted the force-shutdown branch July 23, 2024 17:26
@KeranYang
Copy link
Copy Markdown
Member

Just curious, what drives this change? Was it causing problems? @yhl25

@vigith
Copy link
Copy Markdown
Member

vigith commented Jul 23, 2024

for streaming connections the draining might never end, eg. a reduce whose window size is in minutes.

@KeranYang
Copy link
Copy Markdown
Member

Got it, thanks! @vigith

KeranYang pushed a commit to KeranYang/numaflow-java that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants