fix(bundling): replace rollup-plugin-copy with nx copy assets plugin #33601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading to Nx 21.4.0, TypeScript type-checking fails with "Cannot find type definition file for 'minimatch'" error. This is caused by the transitive dependency chain: [email protected] -> [email protected] -> @types/[email protected] -> @types/minimatch When users run tsc without explicit types configuration, TypeScript auto-discovers @types/minimatch from node_modules but can't properly resolve it. No type errors related to minimatch when running type-check. Fixes #32398
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit c061645
☁️ Nx Cloud last updated this comment at |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: jaysoo <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: jaysoo <[email protected]>
…plugin
Fixes asset path handling in nxCopyAssetsPlugin to prevent double-nested
output directories. When using assets like { input: '.', glob: 'libs/childlib/README.md' },
files now correctly copy to dist/libs/childlib/README.md instead of
dist/libs/childlib/libs/childlib/README.md.
The fix extracts literal directory prefixes from glob patterns and incorporates
them into the input path, ensuring CopyAssetsHandler receives properly normalized
relative paths.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…plugin
Fixes asset path handling in nxCopyAssetsPlugin to prevent double-nested
output directories. When using assets like { input: '.', glob: 'libs/childlib/README.md' },
files now correctly copy to dist/libs/childlib/README.md instead of
dist/libs/childlib/libs/childlib/README.md.
The fix extracts literal directory prefixes from glob patterns and incorporates
them into the input path, ensuring CopyAssetsHandler receives properly normalized
relative paths. [Self-Healing CI Rerun]
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we reran your CI automatically.
🎓 Learn more about Self-Healing CI on nx.dev
leosvelperez
approved these changes
Nov 26, 2025
jaysoo
added a commit
that referenced
this pull request
Nov 26, 2025
…33601) There's a problem when `@nx/rollup` is installed with [email protected], and typechecks. This is caused by the transitive dependency chain: ``` [email protected] -> [email protected] -> @types/[email protected] -> @types/minimatch ``` When users run tsc without explicit `types` configuration, TypeScript auto-discovers `@types/minimatch` from `node_modules` but can't properly resolve it. Note: This doesn't happen with NPM and PNPM, nor newer yarn versions. Verified fix with this repro: https://github.com/jaysoo/rollup-251124 Fixes #32398 --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: jaysoo <[email protected]>
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 27, 2025
…33601) There's a problem when `@nx/rollup` is installed with [email protected], and typechecks. This is caused by the transitive dependency chain: ``` [email protected] -> [email protected] -> @types/[email protected] -> @types/minimatch ``` When users run tsc without explicit `types` configuration, TypeScript auto-discovers `@types/minimatch` from `node_modules` but can't properly resolve it. Note: This doesn't happen with NPM and PNPM, nor newer yarn versions. Verified fix with this repro: https://github.com/jaysoo/rollup-251124 Fixes #32398 --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: jaysoo <[email protected]> (cherry picked from commit 017ad93)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a problem when
@nx/rollupis installed with [email protected], and typechecks.This is caused by the transitive dependency chain:
When users run tsc without explicit
typesconfiguration, TypeScript auto-discovers@types/minimatchfromnode_modulesbut can't properly resolve it.Note: This doesn't happen with NPM and PNPM, nor newer yarn versions.
Verified fix with this repro: https://github.com/jaysoo/rollup-251124
Fixes #32398