Skip to content

fix: flatten path separators in pack output filename #9468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owlstronaut merged 1 commit into from
Jun 2, 2026
Merged

fix: flatten path separators in pack output filename #9468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workspaces/libnpmpack/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ async function pack (spec = 'file:.', opts = {}) {
// check for explicit `false` so the default behavior is to skip writing to disk
if (opts.dryRun === false) {
const filename = `${manifest.name}-${manifest.version}.tgz`
.replace(/^@/, '').replace(/\//, '-')
.replace(/^@/, '').replace(/[/\\]/g, '-')
const destination = path.resolve(opts.packDestination, filename)
await writeFile(destination, tarball)
}
Expand Down
23 changes: 23 additions & 0 deletions workspaces/libnpmpack/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,29 @@ t.test('packs from local directory', async t => {
})
})

t.test('flattens path separators in name so tarball stays in packDestination', async t => {
const testDir = t.testdir({
src: {
'package.json': JSON.stringify({
name: 'x/../../../../../../escaped',
version: '1.0.0',
}, null, 2),
},
dest: {},
})

const dest = path.join(testDir, 'dest')
await pack(`file:${path.join(testDir, 'src')}`, {
dryRun: false,
packDestination: dest,
silent: true,
})

const written = fs.readdirSync(dest)
t.same(written, ['x-..-..-..-..-..-..-escaped-1.0.0.tgz'], 'separators flattened to a single filename')
t.notOk(fs.existsSync(path.join(testDir, 'escaped-1.0.0.tgz')), 'nothing escaped the destination')
})

t.test('writes tarball to file when dryRun === false', async t => {
const testDir = t.testdir({
'package.json': JSON.stringify({
Expand Down
Loading