Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 94.16% 94.16%
=======================================
Files 40 40
Lines 2382 2383 +1
=======================================
+ Hits 2243 2244 +1
Misses 139 139 ☔ View full report in Codecov by Sentry. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a "历史测试" section to published GitHub actions comment renderings, ensuring historical test runs are always displayed.
- Inserts
<details>blocks with historical test entries in all relevant render tests. - Refactors
render_commentto unifyaction_urlhandling and always append history entries. - Updates the changelog to document this fix.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/plugins/github/publish/render/test_publish_render_error.py | Added historical test <details> block to error rendering test |
| tests/plugins/github/publish/render/test_publish_render_data.py | Added historical test <details> block to data rendering test |
| tests/plugins/github/publish/render/test_publish_render.py | Added historical test <details> block to general rendering tests |
| tests/plugins/github/publish/process/test_publish_check.py | Added historical test <details> block to process publish-check tests |
| src/plugins/github/plugins/publish/render.py | Refactored action_url assignment and history appending logic |
| CHANGELOG.md | Documented the fix under "Unreleased" |
BigOrangeQWQ
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
任何时候都应该显示历史测试，因为 #394 和 #401 依赖其提供数据。