Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to display Noneflow run history in workflow comments. Key changes include removing unused fields from snapshot comparisons in tests, refactoring comment APIs to use a new resuable comment mechanism, and incorporating workflow history parsing and rendering in both utils and templates.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/providers/docker_test/test_docker_plugin_test.py | Removed unused metadata/config fields from snapshot assertions. |
| tests/plugins/github/publish/utils/test_history_workflow.py | Added tests to verify parsing of workflow history from comments. |
| tests/plugins/github/publish/utils/test_comment_issue.py | Updated tests to use the new resuable_comment_issue API. |
| tests/plugins/github/render/test_publish_render_error.py | Updated test functions to accept an additional mock_datetime parameter and include history details. |
| tests/plugins/github/publish/render/test_publish_render_data.py | Added history test details in rendered comment snapshots. |
| tests/plugins/github/publish/process/test_publish_check_plugin.py | Added history details in plugin check tests. |
| src/plugins/github/plugins/remove/init.py, src/plugins/github/plugins/config/init.py | Updated calls to use resuable_comment_issue for comment reuse. |
| src/plugins/github/plugins/publish/utils.py | Added history workflow parsing support and new constant definitions. |
| src/plugins/github/plugins/publish/templates/comment.md.jinja | Inserted history test details block in the comment template. |
| src/plugins/github/plugins/publish/render.py | Modified render_comment to accept and include workflow history. |
| src/plugins/github/plugins/publish/init.py | Integrated workflow history retrieval and passing into render_comment. |
| src/plugins/github/handlers/issue.py, src/plugins/github/handlers/github.py | Refactored comment API methods to support comment reuse with history retrieval. |
| tests/conftest.py | Set datetime mocking fixture to autouse for reliable datetime outputs. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 93.67% 93.72% +0.04%
==========================================
Files 41 41
Lines 2278 2311 +33
==========================================
+ Hits 2134 2166 +32
- Misses 144 145 +1 ☔ View full report in Codecov by Sentry. |
a6b2ff4 to
4795e25
Compare
he0119
reviewed
May 27, 2025
he0119
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #370