Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces visual card components to display plugin test results using badge markdown in various test files and updates the rendering functionality accordingly.
- Added badge markdown for homepage and test results in multiple test files.
- Updated the render_comment function in the publish render module to incorporate the new card badges.
- Defined a COMMENT_CARD_TEMPLATE constant and introduced inline snapshot configuration in pyproject.toml.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/plugins/github/publish/render/test_publish_render_error.py | Added badge markdown for homepage and error test results. |
| tests/plugins/github/publish/render/test_publish_render_data.py | Added badge markdown for homepage and OK test results. |
| tests/plugins/github/publish/process/test_publish_check_plugin.py | Included badge markdown for homepage and OK test results. |
| tests/plugins/github/publish/process/test_publish_check.py | Added badge markdown for homepage in various tests. |
| tests/plugins/github/config/process/test_config_check.py | Included badge markdown for homepage and OK test results. |
| src/plugins/github/plugins/publish/render.py | Updated badge card generation in render_comment. |
| src/plugins/github/plugins/publish/constants.py | Added a constant for the COMMENT_CARD_TEMPLATE. |
| pyproject.toml | Introduced inline snapshot configurations. |
Files not reviewed (1)
- src/plugins/github/plugins/publish/templates/comment.md.jinja: Language not supported
edbc4a2 to
90d2001
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 93.65% 93.66% +0.01%
==========================================
Files 41 41
Lines 2269 2274 +5
==========================================
+ Hits 2125 2130 +5
Misses 144 144 ☔ View full report in Codecov by Sentry. |
he0119
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #237