fix(tools): remove unused validate_repo_manifests backward-compat aliases

[djm81]

Removes _registry_module_ids and _validate_manifest_bundle_dependency_refs module-level assignments. They were unused (no repo references; unit tests use registry_module_ids / validate_manifest_bundle_dependency_refs) and triggered GitHub code-quality unused-global notes.

Made with Cursor

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0920cc3e-91fa-43cc-b09b-cacfc74e21dd

📥 Commits

Reviewing files that changed from the base of the PR and between a83b6f5 and af4fd76.

📒 Files selected for processing (1)

• tools/validate_repo_manifests.py

💤 Files with no reviewable changes (1)

• tools/validate_repo_manifests.py

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: quality (3.13)
• GitHub Check: quality (3.12)
• GitHub Check: quality (3.11)

---

📝 Walkthrough

Internal Tooling Cleanup: Remove Unused Backward-Compatibility Aliases

Impact: Internal development tools only; no manifest, registry, bundle, or API surface changes.

Changes Made

Removed two unused module-level backward-compatibility aliases from tools/validate_repo_manifests.py:

• _registry_module_ids = registry_module_ids
• _validate_manifest_bundle_dependency_refs = validate_manifest_bundle_dependency_refs

These aliases had zero references in the repository and only triggered GitHub code-quality "unused-global" notifications. Unit tests reference the non-prefixed function names exclusively (validated in tests/unit/test_validate_repo_manifests_bundle_deps.py).

Bundle and Module Surface

No changes to command behavior, adapters, or bridge/runtime integration. The validate_repo_manifests module continues validating bundle manifests and registry/index.json with identical functionality.

Manifest and Integrity

No changes to manifest validation logic, registry schema checks, or module-package.yaml requirements. The underlying validator remains unchanged; only dead code removed.

Cross-Repo Impacts

None. These aliases were never part of the public module API exported from specfact-cli-modules and required no specfact-cli changes.

Documentation and Release

No documentation or CHANGELOG updates required. This is internal maintenance cleanup with no user-facing or API-level implications.

Walkthrough

Removed two backward-compatibility alias exports (_registry_module_ids and _validate_manifest_bundle_dependency_refs) from the validation tools module. These aliases previously provided compatibility shims to renamed functions. No functional logic or error handling was modified.

Changes

Cohort / File(s)	Summary
Backward-compatibility alias removal tools/validate_repo_manifests.py	Deleted two module-level aliases that referenced registry_module_ids and validate_manifest_bundle_dependency_refs. This removes legacy compatibility shims; code relying on the underscore-prefixed names will need to update to the canonical function names.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is minimal and lacks required sections (Summary refs, Scope checklist, Bundle Impact, Validation Evidence, CI checks, Docs updates, and final Checklist).	Expand the description to follow the template structure, including Summary with issue references, Scope checklist, Bundle Impact listing, and validation evidence from local gates and CI jobs.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows Conventional Commits style with 'fix:' prefix and clearly describes the removal of unused backward-compatibility aliases.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/validate-repo-remove-dead-aliases

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}