Conversation
ronag
approved these changes
Jul 22, 2021
Member
|
I'm surprised the |
Codecov Report
@@ Coverage Diff @@
## main #896 +/- ##
==========================================
- Coverage 99.57% 99.48% -0.10%
==========================================
Files 26 26
Lines 2131 2132 +1
==========================================
- Hits 2122 2121 -1
- Misses 9 11 +2
Continue to review full report at Codecov.
|
Member
Author
|
@ronag I've updated this. |
ronag
approved these changes
Jul 22, 2021
ronag
reviewed
Jul 22, 2021
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* unref() connectTimeout * clear out the connect timeout in all cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have seen the close of my processes being severely delayed by this.
I'm not sure how to test this though.