HTML validation fixes#2399
HTML validation fixes#2399Trott merged 10 commits intonodejs:masterfrom XhmikosR:master-xmr-html-valid
Conversation
|
I wonder if someone could help make the datetime change modular or something? |
1. Do not show the current choosen language unless your want to choose for a new one. 2. Show tooltip when moving your mouse onto the language symbol for the choosen language.
|
Perhaps strftime offers a helper method which outputs the ISO date for us? Either way I think it'd be better if we moved this to a new handlebars helper. I'm not 100% sure my solution is proper, although it does pass HTML validation. |
There's one case where date is set to `null`.
|
Can we get this merged so that I move forward with the rest of the errors? |
|
/ping @nodejs/website Reviews? |
|
If it helps this is how I check these (apart from visually ofc :)) https://travis-ci.org/XhmikosR/nodejs.org/builds/574836937 When I'm done with most of the warnings I'll make a PR to add the check. It's quite important because that's how I've found broken anchors, broken generated HTML and more. |
|
This is how it was https://travis-ci.org/XhmikosR/nodejs.org/builds/571381047 That branch has more patches from my other PRs but you get the gist. |
|
One request, though. Please do not squash the patches. It's better to track the changes if they are separate patches. |
…fleet.md Co-Authored-By: Chayoung You <yousbe@gmail.com>
| <p><span class="code">npm install -g fleet</span> and <a href="https://github.com/substack/fleet">check out the code on github</a>! </p> | ||
|
|
||
| <img src="http://substack.net/images/fleet.png" width="849" height="568"> | ||
| <img src="http://substack.net/images/fleet.png" alt="fleet" width="849" height="568"> |
There was a problem hiding this comment.
The image is a 404. Can we just remove the img tag entirely?
|
We can remove the 404 image later I guess (which seems to be the plan from the comment) so...landing. |
|
Argh! I squashed and you asked for no-squash! I'm going to force-push to fix.... |
|
Re-landed as 34a36db...bae664a |
Refs #2398