-
-
Notifications
You must be signed in to change notification settings - Fork 34.3k
test_runner: make it compatible with fake timers #59272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcollina
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
mcollina:compatibility-with-fake-timers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <[email protected]>
Collaborator
|
Review requested:
|
Member
|
Can you please add a test? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59272 +/- ##
==========================================
- Coverage 90.24% 89.99% -0.26%
==========================================
Files 630 649 +19
Lines 185688 192130 +6442
Branches 36403 37651 +1248
==========================================
+ Hits 167569 172900 +5331
- Misses 10997 11850 +853
- Partials 7122 7380 +258
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Jul 29, 2025
atlowChemi
approved these changes
Jul 29, 2025
MoLow
approved these changes
Aug 11, 2025
avivkeller
approved these changes
Jan 3, 2026
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
setTimeoutis monkey-patched, it might be missing the symbol. Moreover, we plan to remove it in the future anyway in #58689.