Skip to content

Conversation

@mcollina
Copy link
Member

If setTimeout is monkey-patched, it might be missing the symbol. Moreover, we plan to remove it in the future anyway in #58689.

@mcollina mcollina requested a review from rluvaton July 29, 2025 09:46
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jul 29, 2025
@rluvaton
Copy link
Member

Can you please add a test?

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.99%. Comparing base (2204587) to head (494d33b).
⚠️ Report is 1835 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59272      +/-   ##
==========================================
- Coverage   90.24%   89.99%   -0.26%     
==========================================
  Files         630      649      +19     
  Lines      185688   192130    +6442     
  Branches    36403    37651    +1248     
==========================================
+ Hits       167569   172900    +5331     
- Misses      10997    11850     +853     
- Partials     7122     7380     +258     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.37% <100.00%> (+0.04%) ⬆️

... and 316 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 3, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants