Skip to content

perf_hooks: fix loop delay resolution validation #38166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 3 commits into from
Closed

perf_hooks: fix loop delay resolution validation #38166

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc262f7
perf_hooks: fix loop delay resolution validation
aduh95 Apr 9, 2021
667cc36
fixup! perf_hooks: fix loop delay resolution validation
aduh95 Apr 9, 2021
602db53
fixup! perf_hooks: fix loop delay resolution validation
aduh95 Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/internal/perf/event_loop_delay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const {
} = internalBinding('performance');

const {
validateInteger,
validateInt32,
validateObject,
} = require('internal/validators');

Expand Down Expand Up @@ -47,7 +47,7 @@ function monitorEventLoopDelay(options = {}) {
validateObject(options, 'options');

const { resolution = 10 } = options;
validateInteger(resolution, 'options.resolution', 1);
validateInt32(resolution, 'options.resolution', 1);

return new ELDHistogram(new _ELDHistogram(resolution));
}
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-performance-eventloopdelay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const { sleep } = require('internal/util');
);
});

[-1, 0, Infinity].forEach((i) => {
[-1, 0, 2 ** 31, Infinity].forEach((i) => {
assert.throws(
() => monitorEventLoopDelay({ resolution: i }),
{
Expand Down