Skip to content

doc: update onboarding.md for faster exercise completion #18846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

doc: update onboarding.md for faster exercise completion #18846

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e75d8f
doc: update onboarding.md for faster exercise completion
Trott Feb 18, 2018
78e1b43
squash: maclover7 request
Trott Feb 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion doc/onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,9 @@ onboarding session.
* Collaborators are in alphabetical order by GitHub username.
* Optionally, include your personal pronouns.
* Label your pull request with the `doc` subsystem label.
* Run CI on your PR.
* Run CI on the PR. Because the PR does not affect any code, use either the
`node-test-pull-request-lite` CI task or else cancel the CI run after the
Copy link
Contributor

@maclover7 maclover7 Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explicitly mention node-test-pull-request in the sentence as the alternative, just to avoid being ambiguous

Copy link
Member Author

@Trott Trott Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done!

linter and one other subtask have passed.
* After one or two approvals, land the PR (PRs of this type do not need to wait
for 48/72 hours to land).
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
Expand Down