Skip to content

Add tests to improve internal/crypto/diffiehellman.js coverage #17728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leko wants to merge 4 commits into from
Closed

Add tests to improve internal/crypto/diffiehellman.js coverage #17728

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51da57a
test: add test call DiffieHellman without new keyword
Leko Dec 18, 2017
88cac15
test: add test call DiffieHellmanGroup without new keyword
Leko Dec 18, 2017
d7fa119
test: add test call ECDH without new keyword
Leko Dec 18, 2017
86a5774
test: fix variable name
Leko Dec 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions test/parallel/test-crypto-dh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,28 @@ assert.strictEqual(secret2.toString('base64'), secret1);
assert.strictEqual(dh1.verifyError, 0);
assert.strictEqual(dh2.verifyError, 0);

{
const DiffieHellman = crypto.DiffieHellman;
const dh = DiffieHellman(p1, 'buffer');
assert(dh instanceof DiffieHellman, 'DiffieHellman is expected to return a ' +
'new instance when called without `new`');
}

{
const DiffieHellmanGroup = crypto.DiffieHellmanGroup;
const dh = DiffieHellmanGroup('modp5');
assert(dh instanceof DiffieHellmanGroup, 'DiffieHellmanGroup is expected to' +
' return a new instance when ' +
'called without `new`');
}

{
const ECDH = crypto.ECDH;
const dh = ECDH('prime256v1');
Copy link
Member

@lpinca lpinca Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: how about changing the variable name to ecdh?

Copy link
Contributor Author

@Leko Leko Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review.
I fixed variable names.

assert(dh instanceof ECDH, 'ECDH is expected to return a new instance when ' +
'called without `new`');
}

[
[0x1, 0x2],
() => { },
Expand Down