Normalize win32 library names#3189
Merged
lukekarrys merged 2 commits intonodejs:mainfrom Jul 29, 2025
Merged
Conversation
StefanStojanovic
approved these changes
Jul 24, 2025
Contributor
StefanStojanovic
left a comment
There was a problem hiding this comment.
I see no issues with this as long as all of the checks pass.
Contributor
|
The failing Windows 2019 test is removed in: |
Contributor
Author
|
Checks are passing. |
lukekarrys
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
I ran into this cross-compiling on a case-sensitive file-system. The official sdk includes this file:
VC/Tools/MSVC/14.44.35207/lib/x64/delayimp.libwhich does not have any casing. For simplicity, its easiest to list libraries with lower case names.