win: add an arch check to VS 2019#3025
Merged
StefanStojanovic merged 1 commit intonodejs:mainfrom Apr 23, 2024
Merged
Conversation
richardlau
approved these changes
Apr 18, 2024
Contributor
|
GH action failure was unrelated, I reran it and now all is green. |
Contributor
|
If there are no objections until tomorrow, I'm going to land this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
The
msbuildPathwas wrong on ARM64 machines when Visual Studio 2019 was used. I've fixed this by using the corresponding path for the ARM64 machines if the Visual Studio version is 2019.I also removed the workaround here: 0bab6a0#diff-c4ed6cb32588722371276d96a40ec39364f8c4a8ab39d9489cd5b939c05147b6
Fixes: #3014