Allow SetWeak() for non-object persistent handles. #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI failure is a node-gyp incompatibility with Node.js v0.8.28 (!): Details |
The definition of the SetWeak() template method constrained the type to types with a GetAlignedPointerFromInternalField() method. In practice that meant it only worked with T=v8::Object. Lift that restriction so that e.g. T=v8::External now also works. Note that `SetWeak(WeakCallbackType::kInternalFields)` for types without the aforementioned method will result in a run-time assertion.
Member
Author
|
Rebased onto master. CI should be passing now that #826 is merged. |
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of the SetWeak() template method constrained the type to
types with a GetAlignedPointerFromInternalField() method. In practice
that meant it only worked with T=v8::Object.
Lift that restriction so that e.g. T=v8::External now also works. Note
that
SetWeak(WeakCallbackType::kInternalFields)for types without theaforementioned method will result in a run-time assertion.
I wrote this over a year ago but I forgot to PR it. I don't need it now but I did want it at the time and it still seems useful so here goes.