Remove some code duplication in bindings #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39e97e0 to
00b434f
Compare
Member
|
Thanks! Proposed few cosmetic changes |
yurymalkov
reviewed
Sep 19, 2022
Member
yurymalkov
left a comment
There was a problem hiding this comment.
Oops. Forgot to send the review
python_bindings/bindings.cpp
Outdated
|
|
||
|
|
||
| inline void get_input_array_shapes(const py::buffer_info& buffer, size_t* rows, size_t* features) { | ||
| if (buffer.ndim != 2 && buffer.ndim != 1) throw std::runtime_error("data must be a 1d/2d array"); |
Member
There was a problem hiding this comment.
Suggested change
| if (buffer.ndim != 2 && buffer.ndim != 1) throw std::runtime_error("data must be a 1d/2d array"); | |
| if (buffer.ndim != 2 && buffer.ndim != 1) throw std::runtime_error("Input vector data wrong shape. Data must be a 1D or 2D array"); |
Contributor
Author
There was a problem hiding this comment.
I also added logging of actual number of dimensions in the error message
41a77e4 to
9921073
Compare
9921073 to
97e7009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new functions
get_input_array_shapesandget_input_ids_and_check_shapesto remove code duplicationSmall refactoring: added spaces