fix(video): video fullscreen on ios devices#2074
Merged
ChristophWurst merged 1 commit intomasterfrom Nov 29, 2023
Merged
Conversation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
ef5e8c3 to
ad76d4b
Compare
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
szaimen
approved these changes
Nov 29, 2023
Contributor
szaimen
left a comment
There was a problem hiding this comment.
I dont have an iphone so cannot test but heard that it works so fine by me
artonge
approved these changes
Nov 29, 2023
Member
the rumor spread quickly |
This was referenced Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been tested on an iPhone, an iPad and in the browser. It now works on iPhone and there are no regressions on the other tested devices.
Before
After