Use session locking to be compatible with Nextcloud 25 during logout#677
Merged
Use session locking to be compatible with Nextcloud 25 during logout#677
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
9 tasks
4 tasks
Member
|
/backport to stable25 |
come-nc
approved these changes
Dec 12, 2022
Member
|
failing test unrelated, it also fails on master |
|
The backport to stable25 failed. Please do this backport manually. |
Member
|
right, so there are no stable branches here, no backport needed then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix to fix nextcloud/server#35708 but makes sense anyways to have consistent session locking for the full logout method.
nextcloud/server#35723 could be considered hardening for the server method so this PR allows fixing the issue separtely without requiring the server PR.