Do IMAP auth over direct socket connection#49
Merged
violoncelloCH merged 7 commits intomasterfrom Mar 15, 2019
Merged
Conversation
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
MariusBluem
reviewed
Mar 14, 2019
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
This reverts commit 9df4e31.
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
patschi
referenced
this pull request
in mailcow/mailcow-dockerized
Mar 15, 2019
This was referenced Mar 16, 2019
|
Just a bit of information, I needed to use the following in the config.php: (I needed to explicitly use the mail server name, rather than 127.0.0.1, and I had to put single quotes around the ssl parameter, otherwise nextcloud had an error) 'user_backends' => array( |
Member
Author
|
@philtrick-twm yes, thank you, see #52 and #53 |
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #44
fixes #13
Like proposed in #44 we took the implementation of roundcube but stripped away everything that's not needed for the authentication.
ref: https://github.com/roundcube/roundcubemail/blob/master/program/lib/Roundcube/rcube_imap_generic.php
as we're not using the php-imap (imap_open) library, this dependency isn't needed any more, however we need some different parameters to be set, so the configuration is different and needs to be changed on running instances (see https://github.com/nextcloud/user_external/blob/ec7929ab6aaaf97eb05b419c9d5b82544d629959/README.md vs. the current one)
thank you very much @ChristophWurst for your help!
cc @nextcloud/user_external @hcderaad @patschi @andryyy @lsbbs