Merged
Conversation
Member
Author
|
This currently has the side effect that regular lists will only be converted after typing the first character after |
e9976d7 to
39fb229
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
39fb229 to
4c6b17b
Compare
jancborchardt
approved these changes
Dec 24, 2020
Member
jancborchardt
left a comment
There was a problem hiding this comment.
Great stuff, looks good design-wise! :)
Member
stefan-niedermann
left a comment
There was a problem hiding this comment.
Nice! (Sorry, didn't check the code, but only the screen record)
- Does it also work if there is a space character between the brackets like
- [ ]? - Wouldn't it make more sense to replace the graphical checkbox when pressing backspack with the text representation
- [ ]instead of removing it completely? At least for me this is the expexted behavior, but i don't insist to keep it, it's just well-known to me.
Member
Author
Yes, that is the case.
Moved to #1307 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:

After:
